summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2014-08-06 16:34:27 +1000
committerNeilBrown <neilb@suse.de>2014-08-06 16:34:27 +1000
commit1bdb20e16166240a4ca3b861c48defefaf218874 (patch)
treebd51b756f9336fa0fc0ed52867e51a489ef0609f
parentaf5628f05db62c656f994b2346897939b5110d6a (diff)
md: check for bitmap compatability when changing raid levels.
If an array has a bitmap, then it cannot be converted to a level which does not support bitmaps. Reported-by: Xiao Ni <xni@redhat.com> Signed-off-by: NeilBrown <neilb@suse.de>
-rw-r--r--drivers/md/md.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c
index 1379b1a3b9ff..3bd13b276e45 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3500,6 +3500,12 @@ level_store(struct mddev *mddev, const char *buf, size_t len)
mdname(mddev), clevel);
return -EINVAL;
}
+ if (mddev->bitmap && !pers->quiesce) {
+ module_put(pers->owner);
+ printk(KERN_WARNING "md: %s: %s does not support a bitmap\n",
+ mdname(mddev), clevel);
+ return -EINVAL;
+ }
rdev_for_each(rdev, mddev)
rdev->new_raid_disk = rdev->raid_disk;