diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2022-05-05 17:20:41 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@gmail.com> | 2022-05-09 12:39:51 -0400 |
| commit | c4ca278a540bd2f99864f198a6ec9b4cb1f1fd44 (patch) | |
| tree | 8d0b92a4f7e09d518666f2525a9eba7f1b83b11f | |
| parent | 211b52d9f8aa6e67135c5456b97bd371cf137880 (diff) | |
bcachefs: Delete bch_writepage
Per Dave Chinner and the xfs folks, .writepage is no longer needed, and
it's better not to define it if .writepages is the intended path.
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
| -rw-r--r-- | fs/bcachefs/fs-io.c | 14 | ||||
| -rw-r--r-- | fs/bcachefs/fs-io.h | 1 | ||||
| -rw-r--r-- | fs/bcachefs/fs.c | 1 |
3 files changed, 0 insertions, 16 deletions
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index 4cb2b2eb4dbe..020e603c3faa 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -1508,20 +1508,6 @@ int bch2_writepages(struct address_space *mapping, struct writeback_control *wbc return ret; } -int bch2_writepage(struct page *page, struct writeback_control *wbc) -{ - struct bch_fs *c = page->mapping->host->i_sb->s_fs_info; - struct bch_writepage_state w = - bch_writepage_state_init(c, to_bch_ei(page->mapping->host)); - int ret; - - ret = __bch2_writepage(page, wbc, &w); - if (w.io) - bch2_writepage_do_io(&w); - - return ret; -} - /* buffered writes: */ int bch2_write_begin(struct file *file, struct address_space *mapping, diff --git a/fs/bcachefs/fs-io.h b/fs/bcachefs/fs-io.h index b24efeaf343e..e073dc837ae9 100644 --- a/fs/bcachefs/fs-io.h +++ b/fs/bcachefs/fs-io.h @@ -15,7 +15,6 @@ int __must_check bch2_write_inode_size(struct bch_fs *, struct bch_inode_info *, loff_t, unsigned); -int bch2_writepage(struct page *, struct writeback_control *); int bch2_readpage(struct file *, struct page *); int bch2_writepages(struct address_space *, struct writeback_control *); diff --git a/fs/bcachefs/fs.c b/fs/bcachefs/fs.c index d462c06899d6..c5801a3f636f 100644 --- a/fs/bcachefs/fs.c +++ b/fs/bcachefs/fs.c @@ -1112,7 +1112,6 @@ static const struct inode_operations bch_special_inode_operations = { }; static const struct address_space_operations bch_address_space_operations = { - .writepage = bch2_writepage, .readpage = bch2_readpage, .writepages = bch2_writepages, .readahead = bch2_readahead, |