diff options
author | Stephen Rothwell <sfr@canb.auug.org.au> | 2009-05-26 16:52:08 +1000 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2009-05-26 16:52:08 +1000 |
commit | 65b45e6428d7fe0453a29f03c474dd2529d8b731 (patch) | |
tree | 18f6d3aafeca5e0d5e3bd89ef4579d37cc9fed9f | |
parent | 3cd8db724bbdd6a21c7b022baaa4f86a87be26a9 (diff) |
Revert "V4L/DVB (11673): v4l2-device: unregister i2c_clients when unregistering the v4l2_device."
This reverts commit d5bc7940d39649210f1affac1fa32f253cc45a81.
-rw-r--r-- | drivers/media/video/v4l2-common.c | 1 | ||||
-rw-r--r-- | drivers/media/video/v4l2-device.c | 13 | ||||
-rw-r--r-- | include/media/v4l2-subdev.h | 5 |
3 files changed, 1 insertions, 18 deletions
diff --git a/drivers/media/video/v4l2-common.c b/drivers/media/video/v4l2-common.c index f96475626da7..e32de9e9b0f3 100644 --- a/drivers/media/video/v4l2-common.c +++ b/drivers/media/video/v4l2-common.c @@ -746,7 +746,6 @@ void v4l2_i2c_subdev_init(struct v4l2_subdev *sd, struct i2c_client *client, const struct v4l2_subdev_ops *ops) { v4l2_subdev_init(sd, ops); - sd->flags |= V4L2_SUBDEV_FL_IS_I2C; /* the owner is the same as the i2c_client's driver owner */ sd->owner = client->driver->driver.owner; /* i2c_client and v4l2_subdev point to one another */ diff --git a/drivers/media/video/v4l2-device.c b/drivers/media/video/v4l2-device.c index e1520bc84f71..ffb425f7c24c 100644 --- a/drivers/media/video/v4l2-device.c +++ b/drivers/media/video/v4l2-device.c @@ -83,19 +83,8 @@ void v4l2_device_unregister(struct v4l2_device *v4l2_dev) v4l2_device_disconnect(v4l2_dev); /* Unregister subdevs */ - list_for_each_entry_safe(sd, next, &v4l2_dev->subdevs, list) { + list_for_each_entry_safe(sd, next, &v4l2_dev->subdevs, list) v4l2_device_unregister_subdev(sd); - if (sd->flags & V4L2_SUBDEV_FL_IS_I2C) { - struct i2c_client *client = v4l2_get_subdevdata(sd); - - /* We need to unregister the i2c client explicitly. - We cannot rely on i2c_del_adapter to always - unregister clients for us, since if the i2c bus - is a platform bus, then it is never deleted. */ - if (client) - i2c_unregister_device(client); - } - } } EXPORT_SYMBOL_GPL(v4l2_device_unregister); diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h index a503e1cee78b..17856081c809 100644 --- a/include/media/v4l2-subdev.h +++ b/include/media/v4l2-subdev.h @@ -230,16 +230,12 @@ struct v4l2_subdev_ops { #define V4L2_SUBDEV_NAME_SIZE 32 -/* Set this flag if this subdev is a i2c device. */ -#define V4L2_SUBDEV_FL_IS_I2C (1U << 0) - /* Each instance of a subdev driver should create this struct, either stand-alone or embedded in a larger struct. */ struct v4l2_subdev { struct list_head list; struct module *owner; - u32 flags; struct v4l2_device *v4l2_dev; const struct v4l2_subdev_ops *ops; /* name must be unique */ @@ -268,7 +264,6 @@ static inline void v4l2_subdev_init(struct v4l2_subdev *sd, BUG_ON(!ops || !ops->core); sd->ops = ops; sd->v4l2_dev = NULL; - sd->flags = 0; sd->name[0] = '\0'; sd->grp_id = 0; sd->priv = NULL; |