summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph Fritz <chf.fritz@googlemail.com>2022-01-12 19:33:21 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-02-05 12:39:58 +0100
commit9c7f8a35c5a83740c0e3ea540b6ad145c50d79aa (patch)
tree9385d35aae35dfad030756b7777dbf1d6b08d629
parent5afee7b2b1b27b9b001c11b671ba1bad57c4ff4f (diff)
ovl: fix NULL pointer dereference in copy up warning
commit 4ee7e4a6c9b298da44029ed9ec8ed23ae49cc209 upstream. This patch is fixing a NULL pointer dereference to get a recently introduced warning message working. Fixes: 5b0a414d06c3 ("ovl: fix filattr copy-up failure") Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com> Cc: <stable@vger.kernel.org> # v5.15 Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--fs/overlayfs/copy_up.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/overlayfs/copy_up.c b/fs/overlayfs/copy_up.c
index 791b1916b098..e040970408d4 100644
--- a/fs/overlayfs/copy_up.c
+++ b/fs/overlayfs/copy_up.c
@@ -145,7 +145,7 @@ static int ovl_copy_fileattr(struct inode *inode, struct path *old,
if (err == -ENOTTY || err == -EINVAL)
return 0;
pr_warn("failed to retrieve lower fileattr (%pd2, err=%i)\n",
- old, err);
+ old->dentry, err);
return err;
}
@@ -178,7 +178,7 @@ static int ovl_copy_fileattr(struct inode *inode, struct path *old,
return 0;
}
pr_warn("failed to retrieve upper fileattr (%pd2, err=%i)\n",
- new, err);
+ new->dentry, err);
return err;
}