diff options
| author | Zijun Hu <quic_zijuhu@quicinc.com> | 2024-12-06 08:52:30 +0800 |
|---|---|---|
| committer | Rob Herring (Arm) <robh@kernel.org> | 2024-12-10 10:52:45 -0600 |
| commit | 5d009e024056ded20c5bb1583146b833b23bbd5a (patch) | |
| tree | fc4fcfd8981db2caf900f59fe5c29e52bfaa1eed | |
| parent | d7dfa7fde63dde4d2ec0083133efe2c6686c03ff (diff) | |
of: Fix refcount leakage for OF node returned by __of_get_dma_parent()
__of_get_dma_parent() returns OF device node @args.np, but the node's
refcount is increased twice, by both of_parse_phandle_with_args() and
of_node_get(), so causes refcount leakage for the node.
Fix by directly returning the node got by of_parse_phandle_with_args().
Fixes: f83a6e5dea6c ("of: address: Add support for the parent DMA bus")
Cc: stable@vger.kernel.org
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20241206-of_core_fix-v1-4-dc28ed56bec3@quicinc.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
| -rw-r--r-- | drivers/of/address.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/of/address.c b/drivers/of/address.c index 5b7ee3ed5296..c1f1c810e810 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -620,7 +620,7 @@ struct device_node *__of_get_dma_parent(const struct device_node *np) if (ret < 0) return of_get_parent(np); - return of_node_get(args.np); + return args.np; } #endif |