diff options
| author | Kent Overstreet <kent.overstreet@gmail.com> | 2019-02-20 16:00:03 -0500 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:08:16 -0400 |
| commit | 86a225c42d44ba966504801c6d953745184ea9cf (patch) | |
| tree | 2b0ea16daf7bacac97176d33a10be235958f5262 | |
| parent | 3c5fa33a55ac2a1539c89635c07eee9fc3823bac (diff) | |
bcachefs: fix a deadlock on startup
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
| -rw-r--r-- | fs/bcachefs/alloc_background.c | 4 | ||||
| -rw-r--r-- | fs/bcachefs/journal_io.c | 9 |
2 files changed, 10 insertions, 3 deletions
diff --git a/fs/bcachefs/alloc_background.c b/fs/bcachefs/alloc_background.c index 04b75367fcde..fd39eeae5740 100644 --- a/fs/bcachefs/alloc_background.c +++ b/fs/bcachefs/alloc_background.c @@ -1678,7 +1678,6 @@ int bch2_fs_allocator_start(struct bch_fs *c) { struct bch_dev *ca; unsigned i; - bool wrote; int ret; down_read(&c->gc_lock); @@ -1697,8 +1696,7 @@ int bch2_fs_allocator_start(struct bch_fs *c) } set_bit(BCH_FS_ALLOCATOR_RUNNING, &c->flags); - - return bch2_alloc_write(c, false, &wrote); + return 0; } void bch2_fs_allocator_background_init(struct bch_fs *c) diff --git a/fs/bcachefs/journal_io.c b/fs/bcachefs/journal_io.c index e5e50be80126..1f7bd314f61e 100644 --- a/fs/bcachefs/journal_io.c +++ b/fs/bcachefs/journal_io.c @@ -888,10 +888,19 @@ err: static unsigned journal_dev_buckets_available(struct journal *j, struct journal_device *ja) { + struct bch_fs *c = container_of(j, struct bch_fs, journal); unsigned next = (ja->cur_idx + 1) % ja->nr; unsigned available = (ja->last_idx + ja->nr - next) % ja->nr; /* + * Allocator startup needs some journal space before we can do journal + * replay: + */ + if (available && + test_bit(BCH_FS_ALLOCATOR_STARTED, &c->flags)) + available--; + + /* * Don't use the last bucket unless writing the new last_seq * will make another bucket available: */ |