diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2022-07-14 11:06:23 -0700 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2022-11-09 19:07:32 -0800 |
| commit | 7347968366748f45fa76637315b720d07866085b (patch) | |
| tree | d748f7a0a099e0bf83710b2950a058efc6b6d9ae | |
| parent | a6a60142cdb488b17324e9d1378bf853b8dab395 (diff) | |
xfs: report symlink block corruption errors to the health system
Whenever we encounter corrupt symbolic link blocks, we should report
that to the health monitoring system for later reporting.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
| -rw-r--r-- | fs/xfs/xfs_symlink.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/fs/xfs/xfs_symlink.c b/fs/xfs/xfs_symlink.c index 8241c0fcd0ba..90de8991cd94 100644 --- a/fs/xfs/xfs_symlink.c +++ b/fs/xfs/xfs_symlink.c @@ -23,6 +23,7 @@ #include "xfs_trans.h" #include "xfs_ialloc.h" #include "xfs_error.h" +#include "xfs_health.h" /* ----- Kernel only functions below ----- */ int @@ -57,6 +58,8 @@ xfs_readlink_bmap_ilocked( error = xfs_buf_read(mp->m_ddev_targp, d, BTOBB(byte_cnt), 0, &bp, &xfs_symlink_buf_ops); + if (xfs_metadata_is_sick(error)) + xfs_inode_mark_sick(ip, XFS_SICK_INO_SYMLINK); if (error) return error; byte_cnt = XFS_SYMLINK_BUF_SPACE(mp, byte_cnt); @@ -67,6 +70,7 @@ xfs_readlink_bmap_ilocked( if (xfs_has_crc(mp)) { if (!xfs_symlink_hdr_ok(ip->i_ino, offset, byte_cnt, bp)) { + xfs_inode_mark_sick(ip, XFS_SICK_INO_SYMLINK); error = -EFSCORRUPTED; xfs_alert(mp, "symlink header does not match required off/len/owner (0x%x/Ox%x,0x%llx)", @@ -120,6 +124,7 @@ xfs_readlink( __func__, (unsigned long long) ip->i_ino, (long long) pathlen); ASSERT(0); + xfs_inode_mark_sick(ip, XFS_SICK_INO_SYMLINK); goto out; } @@ -128,8 +133,10 @@ xfs_readlink( * The VFS crashes on a NULL pointer, so return -EFSCORRUPTED * if if_data is junk. */ - if (XFS_IS_CORRUPT(ip->i_mount, !ip->i_df.if_u1.if_data)) + if (XFS_IS_CORRUPT(ip->i_mount, !ip->i_df.if_u1.if_data)) { + xfs_inode_mark_sick(ip, XFS_SICK_INO_SYMLINK); goto out; + } memcpy(link, ip->i_df.if_u1.if_data, pathlen + 1); error = 0; @@ -139,6 +146,8 @@ xfs_readlink( out: xfs_iunlock(ip, XFS_ILOCK_SHARED); + if (error == -EFSCORRUPTED) + xfs_inode_mark_sick(ip, XFS_SICK_INO_SYMLINK); return error; } @@ -494,6 +503,7 @@ xfs_inactive_symlink( __func__, (unsigned long long)ip->i_ino, pathlen); xfs_iunlock(ip, XFS_ILOCK_EXCL); ASSERT(0); + xfs_inode_mark_sick(ip, XFS_SICK_INO_SYMLINK); return -EFSCORRUPTED; } |