summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2022-07-18 07:00:12 +0200
committerChristoph Hellwig <hch@lst.de>2022-07-26 16:04:22 -0400
commit6aff7378bcebf70317379c369650c5ce88ec0886 (patch)
tree80dfd7014f9db70163162cf71d8fbe157b77e000
parenta66c53b5bae20ef860179b9af8ab52ff1368ee4e (diff)
nvmet: don't check for NULL pointer before kfree in nvmet_host_release
And add an empty line after the variable declaration. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Hannes Reinecke <hare@suse.de>
-rw-r--r--drivers/nvme/target/configfs.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvme/target/configfs.c b/drivers/nvme/target/configfs.c
index e826a22f5e07..2bcd60758919 100644
--- a/drivers/nvme/target/configfs.c
+++ b/drivers/nvme/target/configfs.c
@@ -1808,9 +1808,9 @@ static struct configfs_attribute *nvmet_host_attrs[] = {
static void nvmet_host_release(struct config_item *item)
{
struct nvmet_host *host = to_host(item);
+
#ifdef CONFIG_NVME_TARGET_AUTH
- if (host->dhchap_secret)
- kfree(host->dhchap_secret);
+ kfree(host->dhchap_secret);
#endif
kfree(host);
}