diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-07-18 14:09:32 +0300 |
---|---|---|
committer | Christoph Hellwig <hch@lst.de> | 2022-07-26 16:04:20 -0400 |
commit | 8d37cb45bc7a0fd2dbc5ca956a7e77c26c029f7e (patch) | |
tree | fda3ca1240cad8166086447d07408a5cf73ffa8c | |
parent | 4dfbd5418763018f33acded0871fbbc22c8e4695 (diff) |
nvme-auth: fix off by one checks
The > ARRAY_SIZE() checks need to be >= ARRAY_SIZE() to prevent reading
one element beyond the end of the arrays.
Fixes: a476416bb57b ("nvme: implement In-Band authentication")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r-- | drivers/nvme/common/auth.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/nvme/common/auth.c b/drivers/nvme/common/auth.c index 94cc7cafbb9d..4b146cec9406 100644 --- a/drivers/nvme/common/auth.c +++ b/drivers/nvme/common/auth.c @@ -55,7 +55,7 @@ static struct nvme_auth_dhgroup_map { const char *nvme_auth_dhgroup_name(u8 dhgroup_id) { - if (dhgroup_id > ARRAY_SIZE(dhgroup_map)) + if (dhgroup_id >= ARRAY_SIZE(dhgroup_map)) return NULL; return dhgroup_map[dhgroup_id].name; } @@ -63,7 +63,7 @@ EXPORT_SYMBOL_GPL(nvme_auth_dhgroup_name); const char *nvme_auth_dhgroup_kpp(u8 dhgroup_id) { - if (dhgroup_id > ARRAY_SIZE(dhgroup_map)) + if (dhgroup_id >= ARRAY_SIZE(dhgroup_map)) return NULL; return dhgroup_map[dhgroup_id].kpp; } @@ -110,7 +110,7 @@ static struct nvme_dhchap_hash_map { const char *nvme_auth_hmac_name(u8 hmac_id) { - if (hmac_id > ARRAY_SIZE(hash_map)) + if (hmac_id >= ARRAY_SIZE(hash_map)) return NULL; return hash_map[hmac_id].hmac; } @@ -118,7 +118,7 @@ EXPORT_SYMBOL_GPL(nvme_auth_hmac_name); const char *nvme_auth_digest_name(u8 hmac_id) { - if (hmac_id > ARRAY_SIZE(hash_map)) + if (hmac_id >= ARRAY_SIZE(hash_map)) return NULL; return hash_map[hmac_id].digest; } @@ -144,7 +144,7 @@ EXPORT_SYMBOL_GPL(nvme_auth_hmac_id); size_t nvme_auth_hmac_hash_len(u8 hmac_id) { - if (hmac_id > ARRAY_SIZE(hash_map)) + if (hmac_id >= ARRAY_SIZE(hash_map)) return 0; return hash_map[hmac_id].len; } |