diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2020-06-17 16:17:34 -0500 |
|---|---|---|
| committer | Borislav Petkov <bp@suse.de> | 2020-06-18 13:24:23 +0200 |
| commit | 5ba7821bcf7d82e35582fce8fe65cd160a6954b4 (patch) | |
| tree | 18d2f6410baa811f3b5e8273f5309034bf644788 | |
| parent | 5d7f7d1d5e01c22894dee7c9c9266500478dca99 (diff) | |
x86/mce/dev-mcelog: Use struct_size() helper in kzalloc()
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.
This code was detected with the help of Coccinelle and, audited and
fixed manually.
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Tony Luck <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/20200617211734.GA9636@embeddedor
| -rw-r--r-- | arch/x86/kernel/cpu/mce/dev-mcelog.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/x86/kernel/cpu/mce/dev-mcelog.c b/arch/x86/kernel/cpu/mce/dev-mcelog.c index 43c466020ed5..03e51053592a 100644 --- a/arch/x86/kernel/cpu/mce/dev-mcelog.c +++ b/arch/x86/kernel/cpu/mce/dev-mcelog.c @@ -345,7 +345,7 @@ static __init int dev_mcelog_init_device(void) int err; mce_log_len = max(MCE_LOG_MIN_LEN, num_online_cpus()); - mcelog = kzalloc(sizeof(*mcelog) + mce_log_len * sizeof(struct mce), GFP_KERNEL); + mcelog = kzalloc(struct_size(mcelog, entry, mce_log_len), GFP_KERNEL); if (!mcelog) return -ENOMEM; |