summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLevente Kurusa <levex@linux.com>2014-01-10 12:42:19 +1100
committerStephen Rothwell <sfr@canb.auug.org.au>2014-01-14 16:04:42 +1100
commite5e9b7b5a7827e60f23fabf9e404cb4ba8b211c8 (patch)
tree3c423d8e5c5990ba2135b06e14e39a76a916ee74
parent8f56ad5989985f8949812e2de523b854f9a7a3a1 (diff)
drivers/net/phy/mdio_bus.c: call put_device on device_register() failure
It is required to call put_device() if device_register() fails, so that we give up the last reference to the device. Calling put_device allows for mdiobus_release to be executed, kfreeing the bus. Signed-off-by: Levente Kurusa <levex@linux.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Grant Likely <grant.likely@secretlab.ca> Cc: David Daney <david.daney@cavium.com> Cc: David S. Miller <davem@davemloft.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rw-r--r--drivers/net/phy/mdio_bus.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/phy/mdio_bus.c b/drivers/net/phy/mdio_bus.c
index 930694d3a13f..71e49000fbf3 100644
--- a/drivers/net/phy/mdio_bus.c
+++ b/drivers/net/phy/mdio_bus.c
@@ -150,6 +150,7 @@ int mdiobus_register(struct mii_bus *bus)
err = device_register(&bus->dev);
if (err) {
pr_err("mii_bus %s failed to register\n", bus->id);
+ put_device(&bus->dev);
return -EINVAL;
}