diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-01-21 09:08:05 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-02-03 23:22:22 +0100 |
| commit | 2efc5bfe67024ee56fb5eb831081263895eb5970 (patch) | |
| tree | e764d01b60707c9aa3f04c30c7ca19e7a61378cf | |
| parent | d882652c1c6fc339c5fb9535005f70ee79f11859 (diff) | |
can: dev: prevent potential information leak in can_fill_info()
[ Upstream commit b552766c872f5b0d90323b24e4c9e8fa67486dd5 ]
The "bec" struct isn't necessarily always initialized. For example, the
mcp251xfd_get_berr_counter() function doesn't initialize anything if the
interface is down.
Fixes: 52c793f24054 ("can: netlink support for bus-error reporting and counters")
Link: https://lore.kernel.org/r/YAkaRdRJncsJO8Ve@mwanda
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
| -rw-r--r-- | drivers/net/can/dev.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 1025cfd463ec..0ebee99a3e85 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -1102,7 +1102,7 @@ static int can_fill_info(struct sk_buff *skb, const struct net_device *dev) { struct can_priv *priv = netdev_priv(dev); struct can_ctrlmode cm = {.flags = priv->ctrlmode}; - struct can_berr_counter bec; + struct can_berr_counter bec = { }; enum can_state state = priv->state; if (priv->do_get_state) |