diff options
| author | Qiang.Zhang <qiang.zhang@windriver.com> | 2021-08-31 10:29:19 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-18 13:44:05 +0200 |
| commit | 5ecb17485abe61a4feb62c7dd76d0eb7b8475273 (patch) | |
| tree | f0a50d6280f0aa146daca2f5f3903edaa4684b30 | |
| parent | 39cd7a4389642ec6526f726e6c33e06052e430dd (diff) | |
tracing/osnoise: Fix missed cpus_read_unlock() in start_per_cpu_kthreads()
commit 4b6b08f2e45edda4c067ac40833e3c1f84383c0b upstream.
When start_kthread() return error, the cpus_read_unlock() need
to be called.
Link: https://lkml.kernel.org/r/20210831022919.27630-1-qiang.zhang@windriver.com
Cc: <stable@vger.kernel.org>
Fixes: c8895e271f79 ("trace/osnoise: Support hotplug operations")
Acked-by: Daniel Bristot de Oliveira <bristot@kernel.org>
Signed-off-by: Qiang.Zhang <qiang.zhang@windriver.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | kernel/trace/trace_osnoise.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/trace/trace_osnoise.c b/kernel/trace/trace_osnoise.c index b61eefe5ccf5..7b3c754821e5 100644 --- a/kernel/trace/trace_osnoise.c +++ b/kernel/trace/trace_osnoise.c @@ -1548,7 +1548,7 @@ static int start_kthread(unsigned int cpu) static int start_per_cpu_kthreads(struct trace_array *tr) { struct cpumask *current_mask = &save_cpumask; - int retval; + int retval = 0; int cpu; get_online_cpus(); @@ -1568,13 +1568,13 @@ static int start_per_cpu_kthreads(struct trace_array *tr) retval = start_kthread(cpu); if (retval) { stop_per_cpu_kthreads(); - return retval; + break; } } put_online_cpus(); - return 0; + return retval; } #ifdef CONFIG_HOTPLUG_CPU |