summaryrefslogtreecommitdiff
path: root/arch
diff options
context:
space:
mode:
authorSubramaniam C.A <subramaniam.ca@ti.com>2010-08-13 10:40:28 -0500
committerBryan Wu <bryan.wu@canonical.com>2010-08-26 21:47:23 +0800
commitdf02ea34a80f32289b4277ecc0317d9a15e3327f (patch)
treee4f538d0fd2da2b1e38b14947d9e4df75f0c785a /arch
parent389913b9ffcec818c21f4f67051739add675cfdf (diff)
ARM : OMAP : remoteproc - Removed capability check for start and stop calls
The checks enforces that only root gets to perform start and stop ioctls. This is not desirable for now. Signed-off-by: Subramaniam C.A <subramaniam.ca@ti.com>
Diffstat (limited to 'arch')
-rw-r--r--arch/arm/plat-omap/remoteproc.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/arch/arm/plat-omap/remoteproc.c b/arch/arm/plat-omap/remoteproc.c
index aac4b7af44f0..edabdc6766a8 100644
--- a/arch/arm/plat-omap/remoteproc.c
+++ b/arch/arm/plat-omap/remoteproc.c
@@ -193,13 +193,17 @@ static int omap_rproc_ioctl(struct inode *inode, struct file *filp,
switch (cmd) {
case RPROC_IOCSTART:
- if (!capable(CAP_SYS_ADMIN))
- return -EPERM;
+ /* FIXME: re-visit this check to perform
+ proper permission checks */
+ /* if (!capable(CAP_SYS_ADMIN))
+ return -EPERM; */
rc = rproc_start(rproc, (const void __user *) arg);
break;
case RPROC_IOCSTOP:
- if (!capable(CAP_SYS_ADMIN))
- return -EPERM;
+ /* FIXME: re-visit this check to perform
+ proper permission checks */
+ /* if (!capable(CAP_SYS_ADMIN))
+ return -EPERM; */
rc = rproc_stop(rproc);
break;
case RPROC_IOCGETSTATE: