diff options
author | Jens Axboe <jens.axboe@oracle.com> | 2008-10-30 08:53:02 +0100 |
---|---|---|
committer | Jens Axboe <jens.axboe@oracle.com> | 2008-12-23 12:48:14 +0100 |
commit | 05b24c1e07f4ca4b1bd15d2bcc12d3103753ce06 (patch) | |
tree | 95a4ee8fe43cab9821744d379907426ccc0181c0 /block | |
parent | acf9a512ba7e7e9664e268ca03ce3ab293bc846b (diff) |
block: add comment in blk_rq_timed_out() about why next can not be 0
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Diffstat (limited to 'block')
-rw-r--r-- | block/blk-timeout.c | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/block/blk-timeout.c b/block/blk-timeout.c index 116bbf394fb5..99c3efc706b7 100644 --- a/block/blk-timeout.c +++ b/block/blk-timeout.c @@ -132,7 +132,12 @@ void blk_rq_timed_out_timer(unsigned long data) } } - if (next_set && !list_empty(&q->timeout_list)) + /* + * next can never be 0 here with the list non-empty, since we always + * bump ->deadline to 1 so we can detect if the timer was ever added + * or not. See comment in blk_add_timer() + */ + if (next) mod_timer(&q->timeout, round_jiffies_up(next)); spin_unlock_irqrestore(q->queue_lock, flags); |