summaryrefslogtreecommitdiff
path: root/block
diff options
context:
space:
mode:
authorDarrick J. Wong <darrick.wong@oracle.com>2020-04-29 11:50:48 -0700
committerDarrick J. Wong <darrick.wong@oracle.com>2020-05-06 17:58:40 -0700
commit6edd73db978f1c4c84c3187080eacb33f03523d2 (patch)
tree3f1b18036abee77082dfe708329aee67a2e3d799 /block
parent3aafa39d3758487f6c8813d3035b09ea655ef165 (diff)
xfs: fix an incore inode UAF in xfs_bui_recoverfix-log-recovery_2020-05-06
In xfs_bui_item_recover, there exists a use-after-free bug with regards to the inode that is involved in the bmap replay operation. If the mapping operation does not complete, we call xfs_bmap_unmap_extent to create a deferred op to finish the unmapping work, and we retain a pointer to the incore inode. Unfortunately, the very next thing we do is commit the transaction and drop the inode. If reclaim tears down the inode before we try to finish the defer ops, we dereference garbage and blow up. Therefore, create a way to join inodes to the defer ops freezer so that we can maintain the xfs_inode reference until we're done with the inode. Note: This imposes the requirement that there be enough memory to keep every incore inode in memory throughout recovery. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions