summaryrefslogtreecommitdiff
path: root/drivers/char
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-02-20 12:02:31 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-03-07 21:48:38 +0000
commit316459ba4051fd91237171fdca88920128a646f1 (patch)
tree350de588fd955c63b42305b8f004abcb230a51cf /drivers/char
parentb44abdd29423a77074a9edb462de37f1a09daaab (diff)
char: xilinx_hwicap: Fix NULL vs IS_ERR() bug
The devm_platform_ioremap_resource() function returns error pointers. It never returns NULL. Update the check accordingly. Fixes: 672371832193 ("char: xilinx_hwicap: Modernize driver probe") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Michal Simek <michal.simek@amd.com> Link: https://lore.kernel.org/r/ef647a9c-b1b7-4338-9bc0-28165ec2a367@moroto.mountain Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/char')
-rw-r--r--drivers/char/xilinx_hwicap/xilinx_hwicap.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
index 3aaa4b4d9f08..4f6c3cb8aa41 100644
--- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
+++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
@@ -639,8 +639,8 @@ static int hwicap_setup(struct platform_device *pdev, int id,
dev_set_drvdata(dev, drvdata);
drvdata->base_address = devm_platform_ioremap_resource(pdev, 0);
- if (!drvdata->base_address) {
- retval = -ENODEV;
+ if (IS_ERR(drvdata->base_address)) {
+ retval = PTR_ERR(drvdata->base_address);
goto failed;
}