summaryrefslogtreecommitdiff
path: root/drivers/clocksource/timer-gx6605s.c
diff options
context:
space:
mode:
authorTony Lindgren <tony@atomide.com>2020-08-17 12:24:28 +0300
committerDaniel Lezcano <daniel.lezcano@linaro.org>2020-08-24 13:01:39 +0200
commit164805157f3c6834670afbaff563353c773131f1 (patch)
tree7f2a5a5d657fe32afa94253426d7d1867e406e50 /drivers/clocksource/timer-gx6605s.c
parent400d033f5a599120089b5f0c54d14d198499af5a (diff)
clocksource/drivers/timer-ti-dm: Do reset before enable
Commit 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4") exposed a new issue for type2 dual mode timers on at least omap5 where the clockevent will stop when the SoC starts entering idle states during the boot. Turns out we are wrongly first enabling the system timer and then resetting it, while we must also re-enable it after reset. The current sequence leaves the timer module in a partially initialized state. This issue went unnoticed earlier with ti-sysc driver reconfiguring the timer module until we fixed the issue of ti-sysc reconfiguring system timers. Let's fix the issue by calling dmtimer_systimer_enable() from reset for both type1 and type2 timers, and switch the order of reset and enable in dmtimer_systimer_setup(). Let's also move dmtimer_systimer_enable() and dmtimer_systimer_disable() to do this without adding forward declarations. Fixes: 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume for am3 and am4") Reported-by: H. Nikolaus Schaller" <hns@goldelico.com> Signed-off-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20200817092428.6176-1-tony@atomide.com
Diffstat (limited to 'drivers/clocksource/timer-gx6605s.c')
0 files changed, 0 insertions, 0 deletions