diff options
| author | Gustavo Padovan <gustavo.padovan@collabora.co.uk> | 2014-07-31 09:28:36 +1000 |
|---|---|---|
| committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2014-07-31 09:28:36 +1000 |
| commit | 31bbdc35cab53d9c5d85927f765132a71401c882 (patch) | |
| tree | 5d0befe8cea1da240d00c3ac678ce990a12ff029 /drivers/misc | |
| parent | 46118d77fcfd4761895b4efe41b9b016106133e1 (diff) | |
drivers/misc/ti-st/st_core.c: fix NULL dereference on protocol type check
If the type we receive is greater than ST_MAX_CHANNELS we can't rely on
type as vector index since we would be accessing unknown memory when we use the type
as index.
Unable to handle kernel NULL pointer dereference at virtual address 0000001b
pgd = c0004000
[0000001b] *pgd=00000000
Internal error: Oops: 17 [#1] PREEMPT SMP ARM
Modules linked in: btwilink wl12xx wlcore mac80211 cfg80211 rfcomm bnep bluo
CPU: 0 Tainted: G W (3.4.0+ #15)
PC is at st_int_recv+0x278/0x344
LR is at get_parent_ip+0x14/0x30
pc : [<c03b01a8>] lr : [<c007273c>] psr: 200f0193
sp : dc631ed0 ip : e3e21c24 fp : dc631f04
r10: 00000000 r9 : 600f0113 r8 : 0000003f
r7 : e3e21b14 r6 : 00000067 r5 : e2e49c1c r4 : e3e21a80
r3 : 00000001 r2 : 00000001 r1 : 00000001 r0 : 600f0113
Flags: nzCv IRQs off FIQs on Mode SVC_32 ISA ARM Segment kernel
Control: 10c5387d Table: 9c50004a DAC: 00000015
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'drivers/misc')
| -rw-r--r-- | drivers/misc/ti-st/st_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c index 1972d57aadb3..e7fbc08a0627 100644 --- a/drivers/misc/ti-st/st_core.c +++ b/drivers/misc/ti-st/st_core.c @@ -342,7 +342,7 @@ void st_int_recv(void *disc_data, /* Unknow packet? */ default: type = *ptr; - if (st_gdata->list[type] == NULL) { + if (type >= ST_MAX_CHANNELS || st_gdata->list[type] == NULL) { pr_err("chip/interface misbehavior dropping" " frame starting with 0x%02x", type); goto done; |