summaryrefslogtreecommitdiff
path: root/drivers/ras
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2024-03-06 08:30:46 +0300
committerBorislav Petkov (AMD) <bp@alien8.de>2024-03-06 10:22:19 +0100
commitbd17b7c34fadef645becde1245b9394f69f31702 (patch)
tree39f83088c8c14731d8adc6b7b399d8b5637fc66b /drivers/ras
parent7d19eea51757ad72faf4b0493e5bde85ca62012e (diff)
RAS/AMD/FMPM: Fix off by one when unwinding on error
Decrement the index variable i before the first iteration when freeing the remaining elements on error. Depending on where this fails it could free something from one element beyond the end of the fru_records[] array. [ bp: Massage commit message. ] Fixes: 6f15e617cc99 ("RAS: Introduce a FRU memory poison manager") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de> Link: https://lore.kernel.org/r/6fdec71a-846b-4cd0-af69-e5f6cd12f4f6@moroto.mountain
Diffstat (limited to 'drivers/ras')
-rw-r--r--drivers/ras/amd/fmpm.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/ras/amd/fmpm.c b/drivers/ras/amd/fmpm.c
index 0963c9e7b853..2f4ac9591c8f 100644
--- a/drivers/ras/amd/fmpm.c
+++ b/drivers/ras/amd/fmpm.c
@@ -817,7 +817,7 @@ static int allocate_records(void)
return ret;
out_free:
- for (; i >= 0; i--)
+ while (--i >= 0)
kfree(fru_records[i]);
kfree(fru_records);