diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2023-01-27 13:26:38 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-01-31 10:37:51 +0100 |
| commit | 582cef438551ca6373f8c3901a15947b2c9643b9 (patch) | |
| tree | 252ea3bf49a737bfc9ce26a94b14d0e9243ad5ca /drivers/usb/gadget | |
| parent | 2bf40502badf9bc15a487244dd23ce0b08c306c0 (diff) | |
usg: gadget: Move validation out of lock in webusb_bcdVersion_store()
Validation has nothing to do with any protected data,
move it out of the lock and make code neater.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230127112638.84806-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget')
| -rw-r--r-- | drivers/usb/gadget/configfs.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c index 63dc15b4f6d8..1346b330b358 100644 --- a/drivers/usb/gadget/configfs.c +++ b/drivers/usb/gadget/configfs.c @@ -836,19 +836,15 @@ static ssize_t webusb_bcdVersion_store(struct config_item *item, if (ret) return ret; - mutex_lock(&gi->lock); - ret = is_valid_bcd(bcdVersion); if (ret) - goto out; + return ret; + mutex_lock(&gi->lock); gi->bcd_webusb_version = bcdVersion; - ret = len; - -out: mutex_unlock(&gi->lock); - return ret; + return len; } static ssize_t webusb_bVendorCode_show(struct config_item *item, char *page) |