diff options
| author | Alan Cox <alan@lxorguk.ukuu.org.uk> | 2008-02-20 20:51:45 +0000 |
|---|---|---|
| committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2008-02-22 11:51:12 +1100 |
| commit | 8f1473e7ec3a6d7b456b6168238c103e333f5c81 (patch) | |
| tree | ac348e60ab93c506f1a8592ee439c35d778b87c7 /drivers/usb | |
| parent | 0272fcf8034b97aaf035e55fc57f6aab627714d4 (diff) | |
USB: serial: Note mos7480 and option don't lock modem status
Signed-off-by: Alan Cox <alan@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 1 | ||||
| -rw-r--r-- | drivers/usb/serial/option.c | 1 |
2 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index 869ecd374cb4..55ce0a2890c4 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -1709,6 +1709,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file, if (mos7840_port == NULL) return -ENODEV; + /* FIXME: What locks the port registers ? */ mcr = mos7840_port->shadowMCR; if (clear & TIOCM_RTS) mcr &= ~MCR_RTS; diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index af2674c57414..bd210288806a 100644 --- a/drivers/usb/serial/option.c +++ b/drivers/usb/serial/option.c @@ -353,6 +353,7 @@ static int option_tiocmset(struct usb_serial_port *port, struct file *file, portdata = usb_get_serial_port_data(port); + /* FIXME: what locks portdata fields ? */ if (set & TIOCM_RTS) portdata->rts_state = 1; if (set & TIOCM_DTR) |