diff options
| author | Oliver Neukum <oneukum@suse.com> | 2016-08-17 15:51:55 +0200 |
|---|---|---|
| committer | Jiri Slaby <jslaby@suse.cz> | 2016-10-06 08:22:03 +0200 |
| commit | 67eb69ec167ac7feb03162c7bc909a4747dca1de (patch) | |
| tree | 81827c28df39c1b92e3c4a975bdf1081af4a2d83 /drivers | |
| parent | b682d39e66ad5087303147d9bb9fb4ac57154686 (diff) | |
kaweth: fix firmware download
commit 60bcabd080f53561efa9288be45c128feda1a8bb upstream.
This fixes the oops discovered by the Umap2 project and Alan Stern.
The intf member needs to be set before the firmware is downloaded.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/usb/kaweth.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c index afb117c16d2d..8ba774de3474 100644 --- a/drivers/net/usb/kaweth.c +++ b/drivers/net/usb/kaweth.c @@ -1031,6 +1031,7 @@ static int kaweth_probe( kaweth = netdev_priv(netdev); kaweth->dev = udev; kaweth->net = netdev; + kaweth->intf = intf; spin_lock_init(&kaweth->device_lock); init_waitqueue_head(&kaweth->term_wait); @@ -1141,8 +1142,6 @@ err_fw: dev_dbg(dev, "Initializing net device.\n"); - kaweth->intf = intf; - kaweth->tx_urb = usb_alloc_urb(0, GFP_KERNEL); if (!kaweth->tx_urb) goto err_free_netdev; |