summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorJon Derrick <jonathan.derrick@intel.com>2019-12-31 13:24:19 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2020-01-17 19:45:45 +0100
commit1ef9c81097d0aef4ffc45aa76b9a9f25a10609a3 (patch)
tree6c4c0b7a14c0da6e7aa0f5e8b0083654bd28a040 /drivers
parenta5eedf4e6bba2d4f87af4bebb0c74be90f82b54e (diff)
iommu: Remove device link to group on failure
commit 7d4e6ccd1fb09dbfbc49746ca82bd5c25ad4bfe4 upstream. This adds the missing teardown step that removes the device link from the group when the device addition fails. Signed-off-by: Jon Derrick <jonathan.derrick@intel.com> Fixes: 797a8b4d768c5 ("iommu: Handle default domain attach failure") Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Joerg Roedel <jroedel@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/iommu/iommu.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 1620a6f49989..4b761678a18b 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -613,6 +613,7 @@ err_put_group:
mutex_unlock(&group->mutex);
dev->iommu_group = NULL;
kobject_put(group->devices_kobj);
+ sysfs_remove_link(group->devices_kobj, device->name);
err_free_name:
kfree(device->name);
err_remove_link: