diff options
| author | Johan Hovold <jhovold@gmail.com> | 2012-10-25 13:35:10 +0200 |
|---|---|---|
| committer | Paul Gortmaker <paul.gortmaker@windriver.com> | 2014-02-10 16:11:21 -0500 |
| commit | ba8439dd599756c5364419f173fdfe3ee27e319d (patch) | |
| tree | 591447c6166f21005ed38000bd7578c1b575bade /drivers | |
| parent | ef5ebb463321e2b61e9f88a2ce44eb183a68478d (diff) | |
USB: mos7840: fix port-device leak in error path
commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream.
The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index d891d44501f8..c55d2aa35eaa 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -2565,7 +2565,6 @@ error: kfree(mos7840_port->ctrl_buf); usb_free_urb(mos7840_port->control_urb); kfree(mos7840_port); - serial->port[i] = NULL; } return status; } |