summaryrefslogtreecommitdiff
path: root/fs/bcachefs/darray.h
diff options
context:
space:
mode:
authorKent Overstreet <kent.overstreet@linux.dev>2023-03-15 11:53:51 -0400
committerKent Overstreet <kent.overstreet@linux.dev>2023-10-22 17:09:57 -0400
commit9edbcc72f6987bbb58f113d04e7704b7a84106a6 (patch)
treed083a4cf4801bc83fd222e156513dfdce62dd59a /fs/bcachefs/darray.h
parente1e7ecafe6482464ccc510afb38e1b9b306ce5dc (diff)
bcachefs: Fix bch2_evict_subvolume_inodes()
This fixes a bug in bch2_evict_subvolume_inodes(): d_mark_dontcache() doesn't handle the case where i_count is already 0, we need to grab and put the inode in order for it to be dropped. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/darray.h')
-rw-r--r--fs/bcachefs/darray.h15
1 files changed, 10 insertions, 5 deletions
diff --git a/fs/bcachefs/darray.h b/fs/bcachefs/darray.h
index 519ab9b96e67..978ab7961f1b 100644
--- a/fs/bcachefs/darray.h
+++ b/fs/bcachefs/darray.h
@@ -19,11 +19,11 @@ struct { \
typedef DARRAY(void) darray_void;
-static inline int __darray_make_room(darray_void *d, size_t t_size, size_t more)
+static inline int __darray_make_room(darray_void *d, size_t t_size, size_t more, gfp_t gfp)
{
if (d->nr + more > d->size) {
size_t new_size = roundup_pow_of_two(d->nr + more);
- void *data = krealloc_array(d->data, new_size, t_size, GFP_KERNEL);
+ void *data = krealloc_array(d->data, new_size, t_size, gfp);
if (!data)
return -ENOMEM;
@@ -35,20 +35,25 @@ static inline int __darray_make_room(darray_void *d, size_t t_size, size_t more)
return 0;
}
+#define darray_make_room_gfp(_d, _more, _gfp) \
+ __darray_make_room((darray_void *) (_d), sizeof((_d)->data[0]), (_more), _gfp)
+
#define darray_make_room(_d, _more) \
- __darray_make_room((darray_void *) (_d), sizeof((_d)->data[0]), (_more))
+ darray_make_room_gfp(_d, _more, GFP_KERNEL)
#define darray_top(_d) ((_d).data[(_d).nr])
-#define darray_push(_d, _item) \
+#define darray_push_gfp(_d, _item, _gfp) \
({ \
- int _ret = darray_make_room((_d), 1); \
+ int _ret = darray_make_room_gfp((_d), 1, _gfp); \
\
if (!_ret) \
(_d)->data[(_d)->nr++] = (_item); \
_ret; \
})
+#define darray_push(_d, _item) darray_push_gfp(_d, _item, GFP_KERNEL)
+
#define darray_insert_item(_d, _pos, _item) \
({ \
size_t pos = (_pos); \