diff options
| author | Kent Overstreet <kent.overstreet@linux.dev> | 2023-04-21 03:42:41 -0400 |
|---|---|---|
| committer | Kent Overstreet <kent.overstreet@linux.dev> | 2023-10-22 17:10:00 -0400 |
| commit | 1af5227c1d6b3513106f82808fe163bf0bd70df8 (patch) | |
| tree | 25dd5fa74804838da00d26291bc0f07fd155dfc1 /fs/bcachefs/movinggc.c | |
| parent | 5a21764db13877eb1166baf12d2782ebb38b196e (diff) | |
bcachefs: Kill bch2_verify_bucket_evacuated()
With backpointers, it's now impossible for bch2_evacuate_bucket() to be
completely reliable: it can race with an extent being partially
overwritten or split, which needs a new write buffer flush for the
backpointer to be seen.
This shouldn't be a real issue in practice; the previous patch added a
new tracepoint so we'll be able to see more easily if it is.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Diffstat (limited to 'fs/bcachefs/movinggc.c')
| -rw-r--r-- | fs/bcachefs/movinggc.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/fs/bcachefs/movinggc.c b/fs/bcachefs/movinggc.c index 2d75334c541d..02081ee1a114 100644 --- a/fs/bcachefs/movinggc.c +++ b/fs/bcachefs/movinggc.c @@ -134,13 +134,6 @@ static void move_buckets_wait(struct btree_trans *trans, if (atomic_read(&i->count)) break; - /* - * moving_ctxt_exit calls bch2_write as it flushes pending - * reads, which inits another btree_trans; this one must be - * unlocked: - */ - bch2_verify_bucket_evacuated(trans, i->bucket.k.bucket, i->bucket.k.gen); - list->first = i->next; if (!list->first) list->last = NULL; |