diff options
author | Tariq Toukan <tariqt@mellanox.com> | 2020-06-22 23:26:04 +0300 |
---|---|---|
committer | Sasha Levin <sashal@kernel.org> | 2020-06-29 20:07:58 -0400 |
commit | 31394a198cf91f03e676f7fb829361cf91230b0a (patch) | |
tree | a25be8db9655e9bcb357f9548422b735763a842b /fs/binfmt_flat.c | |
parent | c91b5162af314ad62f061f1047af5edc16a066dd (diff) |
net: Do not clear the sock TX queue in sk_set_socket()
[ Upstream commit 41b14fb8724d5a4b382a63cb4a1a61880347ccb8 ]
Clearing the sock TX queue in sk_set_socket() might cause unexpected
out-of-order transmit when called from sock_orphan(), as outstanding
packets can pick a different TX queue and bypass the ones already queued.
This is undesired in general. More specifically, it breaks the in-order
scheduling property guarantee for device-offloaded TLS sockets.
Remove the call to sk_tx_queue_clear() in sk_set_socket(), and add it
explicitly only where needed.
Fixes: e022f0b4a03f ("net: Introduce sk_tx_queue_mapping")
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Reviewed-by: Boris Pismenny <borisp@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/binfmt_flat.c')
0 files changed, 0 insertions, 0 deletions