diff options
author | Oleg Nesterov <oleg@redhat.com> | 2013-08-08 12:57:14 +1000 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2013-08-08 12:57:14 +1000 |
commit | cf7e727625cd88b1da1ade6f3d51cb40790378dc (patch) | |
tree | d14c2930d15244f2b7ae3e5cb29795d3a4c37e37 /fs/cifs/netmisc.c | |
parent | 7227d77ac8da77de725271baa32401d355553ce6 (diff) |
exec: cleanup the CONFIG_MODULES logic
search_binary_handler() uses "for (try=0; try<2; try++)" to avoid "goto"
but the code looks too complicated and horrible imho. We still need to
check "try == 0" before request_module() and add the additional "break"
for !CONFIG_MODULES case.
Kill this loop and use a simple "bool need_retry" + "goto retry". The
code looks much simpler and we do not even need ifdef's, gcc can optimize
out the "if (need_retry)" block if !IS_ENABLED().
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Evgeniy Polyakov <zbr@ioremap.net>
Cc: Zach Levis <zml@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'fs/cifs/netmisc.c')
0 files changed, 0 insertions, 0 deletions