summaryrefslogtreecommitdiff
path: root/fs/efs
diff options
context:
space:
mode:
authorArnd Bergmann <arnd@arndb.de>2024-02-16 21:23:34 +0100
committerChristian Brauner <brauner@kernel.org>2024-02-20 09:23:52 +0100
commitddb9fd7a544088ed70eccbb9f85e9cc9952131c1 (patch)
treea228929f40733e3398a5b994ea2b6f2a3175d12f /fs/efs
parentcf12445daec01aaa2d27bb34bd7c796a53442c42 (diff)
fs/select: rework stack allocation hack for clang
A while ago, we changed the way that select() and poll() preallocate a temporary buffer just under the size of the static warning limit of 1024 bytes, as clang was frequently going slightly above that limit. The warnings have recently returned and I took another look. As it turns out, clang is not actually inherently worse at reserving stack space, it just happens to inline do_select() into core_sys_select(), while gcc never inlines it. Annotate do_select() to never be inlined and in turn remove the special case for the allocation size. This should give the same behavior for both clang and gcc all the time and once more avoids those warnings. Fixes: ad312f95d41c ("fs/select: avoid clang stack usage warning") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Link: https://lore.kernel.org/r/20240216202352.2492798-1-arnd@kernel.org Reviewed-by: Kees Cook <keescook@chromium.org> Reviewed-by: Andi Kleen <ak@linux.intel.com> Reviewed-by: Jan Kara <jack@suse.cz> Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/efs')
0 files changed, 0 insertions, 0 deletions