summaryrefslogtreecommitdiff
path: root/fs/exportfs
diff options
context:
space:
mode:
authorEric Sandeen <sandeen@redhat.com>2020-08-26 14:11:58 -0700
committerDarrick J. Wong <darrick.wong@oracle.com>2020-08-26 14:13:21 -0700
commitf4020438fab05364018c91f7e02ebdd192085933 (patch)
tree41d1a045a0aad864a63228e69a41b936136fbe08 /fs/exportfs
parent657f101930bc6c5b41bd7d6c22565c4302a80d33 (diff)
xfs: fix boundary test in xfs_attr_shortform_verify
The boundary test for the fixed-offset parts of xfs_attr_sf_entry in xfs_attr_shortform_verify is off by one, because the variable array at the end is defined as nameval[1] not nameval[]. Hence we need to subtract 1 from the calculation. This can be shown by: # touch file # setfattr -n root.a file and verifications will fail when it's written to disk. This only matters for a last attribute which has a single-byte name and no value, otherwise the combination of namelen & valuelen will push endp further out and this test won't fail. Fixes: 1e1bbd8e7ee06 ("xfs: create structure verifier function for shortform xattrs") Signed-off-by: Eric Sandeen <sandeen@redhat.com> Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/exportfs')
0 files changed, 0 insertions, 0 deletions