diff options
author | Darrick J. Wong <djwong@kernel.org> | 2022-07-14 11:06:06 -0700 |
---|---|---|
committer | Darrick J. Wong <djwong@kernel.org> | 2022-10-14 14:16:38 -0700 |
commit | bd57d707a8d0957183b5100f1df763bae8380d82 (patch) | |
tree | 0c7edaf272b70ee5f6a6ff88a6ed2a874b490d62 /fs/vboxsf | |
parent | 0c71d81ba706276343cca509523f6f6f23d829e3 (diff) |
xfs: allow the user to cancel repairs before we start writingrepair-tweaks_2022-10-14
All online repair functions have the same structure: walk filesystem
metadata structures gathering enough data to rebuild the structure,
stage a new copy, and then commit the new copy.
The gathering steps do not write anything to disk, so they are peppered
with xchk_should_terminate calls to avoid softlockup warnings and to
provide an opportunity to abort the repair (by killing xfs_scrub).
However, it's not clear in the code base when is the last chance to
abort cleanly without having to undo a bunch of structure.
Therefore, add one more call to xchk_should_terminate (along with a
comment) providing the sysadmin with the ability to abort before it's
too late and to make it clear in the source code when it's no longer
convenient or safe to abort a repair. As there are only four repair
functions right now, this patch exists more to establish a precedent for
subsequent additions than to deliver practical functionality.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/vboxsf')
0 files changed, 0 insertions, 0 deletions