diff options
| author | Darrick J. Wong <djwong@kernel.org> | 2021-10-22 15:31:05 -0700 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2021-12-15 17:29:29 -0800 |
| commit | bb8092d02d822601113897de29384972342ed1e8 (patch) | |
| tree | b496a8902d1bb28a09623580309e88d66f1193ae /fs/xfs/Kconfig | |
| parent | be31442955a3d225b71223eebc056015fab0d698 (diff) | |
xfs: allow queued AG intents to drain before scrubbingscrub-drain-intents_2021-12-15
Currently, online scrub isn't sufficiently careful about quiescing
allocation groups before checking them. While scrub does take the AG
header locks, it doesn't serialize against chains of AG update intents
that are being processed concurrently. If there's a collision,
cross-referencing between data structures (e.g. rmapbt and refcountbt)
can yield false corruption events; if repair is running, this results in
incorrect repairs.
Fix this by adding to the perag structure the count of active intents
and make scrub wait until there aren't any to continue. This is a
little stupid since transactions can queue intents without taking buffer
locks, but we'll also wait for those transactions.
XXX: should have instead a per-ag rwsem that gets taken as soon as the
AG[IF] are locked and stays held until the transaction commits or moves
on to the next AG? would we rather have a six lock so that intents can
take an ix lock, and not have to upgrade to x until we actually want to
make changes to that ag? is that how those even work??
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/xfs/Kconfig')
| -rw-r--r-- | fs/xfs/Kconfig | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/fs/xfs/Kconfig b/fs/xfs/Kconfig index 7d08a8e92c92..5ad64e173672 100644 --- a/fs/xfs/Kconfig +++ b/fs/xfs/Kconfig @@ -96,6 +96,9 @@ config XFS_RT config XFS_LIVE_HOOKS bool +config XFS_DRAIN_INTENTS + bool + config XFS_ONLINE_SCRUB bool "XFS online metadata check support" default n @@ -103,6 +106,7 @@ config XFS_ONLINE_SCRUB depends on TMPFS && SHMEM depends on SRCU select XFS_LIVE_HOOKS + select XFS_DRAIN_INTENTS help If you say Y here you will be able to check metadata on a mounted XFS filesystem. This feature is intended to reduce |