summaryrefslogtreecommitdiff
path: root/fs/xfs/Makefile
diff options
context:
space:
mode:
authorDarrick J. Wong <djwong@kernel.org>2021-12-13 15:41:30 -0800
committerDarrick J. Wong <djwong@kernel.org>2021-12-15 17:28:51 -0800
commit72c3afb5c1f9c9c6739e7fc4202241e76110bfdc (patch)
treede939aaf66516f4ff727d395db418ffb3b523222 /fs/xfs/Makefile
parentab524bd0102fcad40cbc1dcebaef53d5fa5b27d1 (diff)
xfs: allow the user to cancel repairs before we start writing
All online repair functions have the same structure: walk filesystem metadata structures gathering enough data to rebuild the structure, stage a new copy, and then commit the new copy. The gathering steps do not write anything to disk, so they are peppered with xchk_should_terminate calls to avoid softlockup warnings and to provide an opportunity to abort the repair (by killing xfs_scrub). However, it's not clear in the code base when is the last chance to abort cleanly without having to undo a bunch of structure. Therefore, add one more call to xchk_should_terminate (along with a comment) providing the sysadmin with the ability to abort before it's too late and to make it clear in the source code when it's no longer convenient or safe to abort a repair. As there are only four repair functions right now, this patch exists more to establish a precedent for subsequent additions than to deliver practical functionality. Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Diffstat (limited to 'fs/xfs/Makefile')
0 files changed, 0 insertions, 0 deletions