summaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_inode.c
diff options
context:
space:
mode:
authorDarrick J. Wong <darrick.wong@oracle.com>2019-08-30 15:45:07 -0700
committerDarrick J. Wong <darrick.wong@oracle.com>2019-10-19 10:39:11 -0700
commit3a9783097251676ec0a0b0d1a0bd7234ba618da2 (patch)
treee2bfdd7d59a7e6e069bf0da86185e935a58dd9bb /fs/xfs/xfs_inode.c
parentb7c78188fc41c9f239b4785ae23ec28635480e4f (diff)
xfs: decide if inode needs inactivation
Add a predicate function to decide if an inode needs (deferred) inactivation. Any file that has been unlinked or has speculative preallocations either for post-EOF writes or for CoW qualifies. This function will also be used by the upcoming deferred inactivation patch. Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_inode.c')
-rw-r--r--fs/xfs/xfs_inode.c59
1 files changed, 59 insertions, 0 deletions
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index 7ee858e6aa6b..7894682cd637 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -1798,6 +1798,65 @@ xfs_inactive_ifree(
}
/*
+ * Returns true if we need to update the on-disk metadata before we can free
+ * the memory used by this inode. Updates include freeing post-eof
+ * preallocations; freeing COW staging extents; and marking the inode free in
+ * the inobt if it is on the unlinked list.
+ */
+bool
+xfs_inode_needs_inactivation(
+ struct xfs_inode *ip)
+{
+ struct xfs_mount *mp = ip->i_mount;
+ struct xfs_ifork *cow_ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
+
+ /*
+ * If the inode is already free, then there can be nothing
+ * to clean up here.
+ */
+ if (VFS_I(ip)->i_mode == 0)
+ return false;
+
+ /* If this is a read-only mount, don't do this (would generate I/O) */
+ if (mp->m_flags & XFS_MOUNT_RDONLY)
+ return false;
+
+ /* Try to clean out the cow blocks if there are any. */
+ if (cow_ifp && cow_ifp->if_bytes > 0)
+ return true;
+
+ if (VFS_I(ip)->i_nlink != 0) {
+ int error;
+ bool has;
+
+ /*
+ * force is true because we are evicting an inode from the
+ * cache. Post-eof blocks must be freed, lest we end up with
+ * broken free space accounting.
+ *
+ * Note: don't bother with iolock here since lockdep complains
+ * about acquiring it in reclaim context. We have the only
+ * reference to the inode at this point anyways.
+ *
+ * If the predicate errors out, send the inode through
+ * inactivation anyway, because that's what we did before.
+ * The inactivation worker will ignore an inode that doesn't
+ * actually need it.
+ */
+ if (!xfs_can_free_eofblocks(ip, true))
+ return false;
+ error = xfs_has_eofblocks(ip, &has);
+ return error != 0 || has;
+ }
+
+ /*
+ * Link count dropped to zero, which means we have to mark the inode
+ * free on disk and remove it from the AGI unlinked list.
+ */
+ return true;
+}
+
+/*
* xfs_inactive
*
* This is called when the vnode reference count for the vnode