diff options
author | Kent Overstreet <kent.overstreet@linux.dev> | 2024-04-02 20:42:18 -0400 |
---|---|---|
committer | Kent Overstreet <kent.overstreet@linux.dev> | 2024-04-03 17:50:22 -0400 |
commit | 608c5050dbf4f85d8dc386782516b8514c31ced5 (patch) | |
tree | 8670526702636f8cdc9f649f95bec0c0ea4bb6e1 /fs | |
parent | 805b61812ec3f550e5e7a9c3f310316a0dabf2d8 (diff) |
Revert "fs/9p: remove walk and inode allocation from symlink"
This reverts commit 6bb29327221f66d20013cc26b62d5c261b4d46a7.
Diffstat (limited to 'fs')
-rw-r--r-- | fs/9p/vfs_inode_dotl.c | 33 |
1 files changed, 33 insertions, 0 deletions
diff --git a/fs/9p/vfs_inode_dotl.c b/fs/9p/vfs_inode_dotl.c index 4a8606e3b0f9..c9e67d7334e3 100644 --- a/fs/9p/vfs_inode_dotl.c +++ b/fs/9p/vfs_inode_dotl.c @@ -694,11 +694,14 @@ v9fs_vfs_symlink_dotl(struct mnt_idmap *idmap, struct inode *dir, kgid_t gid; const unsigned char *name; struct p9_qid qid; + struct inode *inode; struct p9_fid *dfid; struct p9_fid *fid = NULL; + struct v9fs_session_info *v9ses; name = dentry->d_name.name; p9_debug(P9_DEBUG_VFS, "%lu,%s,%s\n", dir->i_ino, name, symname); + v9ses = v9fs_inode2v9ses(dir); dfid = v9fs_parent_fid(dentry); if (IS_ERR(dfid)) { @@ -718,6 +721,36 @@ v9fs_vfs_symlink_dotl(struct mnt_idmap *idmap, struct inode *dir, } v9fs_invalidate_inode_attr(dir); + if (v9ses->cache & (CACHE_META|CACHE_LOOSE)) { + /* Now walk from the parent so we can get an unopened fid. */ + fid = p9_client_walk(dfid, 1, &name, 1); + if (IS_ERR(fid)) { + err = PTR_ERR(fid); + p9_debug(P9_DEBUG_VFS, "p9_client_walk failed %d\n", + err); + goto error; + } + + /* instantiate inode and assign the unopened fid to dentry */ + inode = v9fs_get_new_inode_from_fid(v9ses, fid, dir->i_sb); + if (IS_ERR(inode)) { + err = PTR_ERR(inode); + p9_debug(P9_DEBUG_VFS, "inode creation failed %d\n", + err); + goto error; + } + v9fs_fid_add(dentry, &fid); + d_instantiate(dentry, inode); + err = 0; + } else { + /* Not in cached mode. No need to populate inode with stat */ + inode = v9fs_get_inode(dir->i_sb, S_IFLNK, 0); + if (IS_ERR(inode)) { + err = PTR_ERR(inode); + goto error; + } + d_instantiate(dentry, inode); + } error: p9_fid_put(fid); |