diff options
| author | Amir Goldstein <amir73il@gmail.com> | 2018-09-18 16:34:31 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-10-10 08:56:04 +0200 |
| commit | 1c7949a5f63769c6d3a3b41326b7b0a2a43777af (patch) | |
| tree | f9bdc7a7c623f75b1fa4902b3b14e04bd619be8e /fs | |
| parent | c33def1bb3aa413c28da11529cb6c5a44fe35713 (diff) | |
ovl: fix memory leak on unlink of indexed file
commit 63e132528032ce937126aba591a7b37ec593a6bb upstream.
The memory leak was detected by kmemleak when running xfstests
overlay/051,053
Fixes: caf70cb2ba5d ("ovl: cleanup orphan index entries")
Cc: <stable@vger.kernel.org> # v4.13
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/overlayfs/util.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/overlayfs/util.c b/fs/overlayfs/util.c index 6f1078028c66..319a7eeb388f 100644 --- a/fs/overlayfs/util.c +++ b/fs/overlayfs/util.c @@ -531,7 +531,7 @@ static void ovl_cleanup_index(struct dentry *dentry) struct dentry *upperdentry = ovl_dentry_upper(dentry); struct dentry *index = NULL; struct inode *inode; - struct qstr name; + struct qstr name = { }; int err; err = ovl_get_index_name(lowerdentry, &name); @@ -574,6 +574,7 @@ static void ovl_cleanup_index(struct dentry *dentry) goto fail; out: + kfree(name.name); dput(index); return; |