diff options
author | Yan, Zheng <zyan@redhat.com> | 2019-02-11 15:18:52 +0800 |
---|---|---|
committer | Ben Hutchings <ben@decadent.org.uk> | 2019-05-02 21:41:57 +0100 |
commit | cfc479edad62138a73afa42b51f533d1e5f2b96f (patch) | |
tree | 7b804cf3123976556636d2a450c46db6f3173a32 /fs | |
parent | d8fa70d55dbd45da76321d39139f5bdafc26284c (diff) |
ceph: avoid repeatedly adding inode to mdsc->snap_flush_list
commit 04242ff3ac0abbaa4362f97781dac268e6c3541a upstream.
Otherwise, mdsc->snap_flush_list may get corrupted.
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/ceph/snap.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/fs/ceph/snap.c b/fs/ceph/snap.c index fad6f7dfab19..62eeae2aa1f9 100644 --- a/fs/ceph/snap.c +++ b/fs/ceph/snap.c @@ -579,7 +579,8 @@ int __ceph_finish_cap_snap(struct ceph_inode_info *ci, capsnap->size); spin_lock(&mdsc->snap_flush_lock); - list_add_tail(&ci->i_snap_flush_item, &mdsc->snap_flush_list); + if (list_empty(&ci->i_snap_flush_item)) + list_add_tail(&ci->i_snap_flush_item, &mdsc->snap_flush_list); spin_unlock(&mdsc->snap_flush_lock); return 1; /* caller may want to ceph_flush_snaps */ } |