summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorOlivier Brunel <jjk@jjacky.com>2018-10-20 19:39:56 +0200
committerDavid S. Miller <davem@davemloft.net>2018-10-22 19:37:36 -0700
commit876dcf2f3aaa0f68d437b368b93a4c4b81521191 (patch)
tree839b76ae222a0ecd942d4af9a6099336b366d549 /include/linux
parentc94f026fb742b2d3199422751dbc4f6fc0e753d8 (diff)
umh: Add command line to user mode helpers
User mode helpers were spawned without a command line, and because an empty command line is used by many tools to identify processes as kernel threads, this could cause some issues. Notably during killing spree on shutdown, since such helper would then be skipped (i.e. not killed) which would result in the process remaining alive, and thus preventing unmouting of the rootfs (as experienced with the bpfilter umh). Fixes: 449325b52b7a ("umh: introduce fork_usermode_blob() helper") Signed-off-by: Olivier Brunel <jjk@jjacky.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux')
-rw-r--r--include/linux/umh.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/linux/umh.h b/include/linux/umh.h
index 5c812acbb80a..235f51b62c71 100644
--- a/include/linux/umh.h
+++ b/include/linux/umh.h
@@ -44,6 +44,7 @@ struct subprocess_info *call_usermodehelper_setup_file(struct file *file,
int (*init)(struct subprocess_info *info, struct cred *new),
void (*cleanup)(struct subprocess_info *), void *data);
struct umh_info {
+ const char *cmdline;
struct file *pipe_to_umh;
struct file *pipe_from_umh;
pid_t pid;