diff options
| author | Christian Brauner <brauner@kernel.org> | 2025-04-11 17:09:44 +0200 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2025-04-12 14:04:53 +0200 |
| commit | a9d7de0f68b79e5e481967fc605698915a37ac13 (patch) | |
| tree | c038848db5e8c37bcc784fb5602c370c7c560099 /kernel/pid.c | |
| parent | 1e940fff94374d04b6c34f896ed9fbad3d2fb706 (diff) | |
| parent | 17f1b08acf50c0bfb02e21623e53e7e575612b67 (diff) | |
Merge patch series "pidfs: ensure consistent ENOENT/ESRCH reporting"
Christian Brauner <brauner@kernel.org> says:
In a prior patch series we tried to cleanly differentiate between:
(1) The task has already been reaped.
(2) The caller requested a pidfd for a thread-group leader but the pid
actually references a struct pid that isn't used as a thread-group
leader.
as this was causing issues for non-threaded workloads.
But there's cases where the current simple logic is wrong. Specifically,
if the pid was a leader pid and the check races with __unhash_process().
Stabilize this by using the pidfd waitqueue lock.
* patches from https://lore.kernel.org/20250411-work-pidfs-enoent-v2-0-60b2d3bb545f@kernel.org:
pidfs: ensure consistent ENOENT/ESRCH reporting
exit: move wake_up_all() pidfd waiters into __unhash_process()
Link: https://lore.kernel.org/20250411-work-pidfs-enoent-v2-0-60b2d3bb545f@kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'kernel/pid.c')
| -rw-r--r-- | kernel/pid.c | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/kernel/pid.c b/kernel/pid.c index 4ac2ce46817f..26f1e136f017 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -359,11 +359,6 @@ static void __change_pid(struct pid **pids, struct task_struct *task, hlist_del_rcu(&task->pid_links[type]); *pid_ptr = new; - if (type == PIDTYPE_PID) { - WARN_ON_ONCE(pid_has_task(pid, PIDTYPE_PID)); - wake_up_all(&pid->wait_pidfd); - } - for (tmp = PIDTYPE_MAX; --tmp >= 0; ) if (pid_has_task(pid, tmp)) return; |