diff options
| author | Jason Wessel <jason.wessel@windriver.com> | 2010-03-23 08:23:01 -0500 |
|---|---|---|
| committer | Jason Wessel <jason.wessel@windriver.com> | 2010-03-23 08:23:01 -0500 |
| commit | b73874df6bd7f15683341f2a883704a10c30ad85 (patch) | |
| tree | 90d05eec7129e85fdfd2b06d326bb668e873bd66 /kernel | |
| parent | 403c3206ec99bd95ea04866f3106a7e4b4b5e527 (diff) | |
kgdb: have ebin2mem call probe_kernel_write once
Rather than call probe_kernel_write() one byte at a time, process the
whole buffer locally and pass the entire result in one go. This way,
architectures that need to do special handling based on the length can
do so, or we only end up calling memcpy() once.
[sonic.zhang@analog.com: Reported original problem and preliminary patch]
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/debug/gdbstub.c | 23 |
1 files changed, 9 insertions, 14 deletions
diff --git a/kernel/debug/gdbstub.c b/kernel/debug/gdbstub.c index ab29bce4f5f9..ccdf0929f12d 100644 --- a/kernel/debug/gdbstub.c +++ b/kernel/debug/gdbstub.c @@ -293,27 +293,22 @@ int kgdb_hex2long(char **ptr, unsigned long *long_val) /* * Copy the binary array pointed to by buf into mem. Fix $, #, and - * 0x7d escaped with 0x7d. Return a pointer to the character after - * the last byte written. + * 0x7d escaped with 0x7d. Return -EFAULT on failure or 0 on success. + * The input buf is overwitten with the result to write to mem. */ static int kgdb_ebin2mem(char *buf, char *mem, int count) { - int err = 0; - char c; + int size = 0; + char *c = buf; while (count-- > 0) { - c = *buf++; - if (c == 0x7d) - c = *buf++ ^ 0x20; - - err = probe_kernel_write(mem, &c, 1); - if (err) - break; - - mem++; + c[size] = *buf++; + if (c[size] == 0x7d) + c[size] = *buf++ ^ 0x20; + size++; } - return err; + return probe_kernel_write(mem, c, size); } /* Write memory due to an 'M' or 'X' packet. */ |