diff options
author | Jiri Slaby <jirislaby@gmail.com> | 2009-08-28 14:08:17 +0200 |
---|---|---|
committer | Jiri Slaby <jirislaby@gmail.com> | 2009-11-24 13:31:21 +0100 |
commit | 1452d512cae33c92f250849750796dfea2114a8e (patch) | |
tree | 22b028421c8d119547b57ed8d5345423bc6d07c5 /kernel | |
parent | c726924108b1e45760fd288a30d8f224a73f6dbe (diff) |
core: allow setrlimit to non-current tasks
Add locking to allow setrlimit accept task parameter other than
current.
Namely, lock tasklist_lock for read and check whether the task
structure has sighand non-null. Do all the signal processing under
that lock still held.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Diffstat (limited to 'kernel')
-rw-r--r-- | kernel/sys.c | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/kernel/sys.c b/kernel/sys.c index 398f9e1934ae..3082eaf4f2c9 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1238,6 +1238,7 @@ SYSCALL_DEFINE2(old_getrlimit, unsigned int, resource, #endif +/* make sure you are allowed to change @tsk limits before calling this */ int setrlimit(struct task_struct *tsk, unsigned int resource, struct rlimit *new_rlim) { @@ -1249,9 +1250,16 @@ int setrlimit(struct task_struct *tsk, unsigned int resource, if (resource == RLIMIT_NOFILE && new_rlim->rlim_max > sysctl_nr_open) return -EPERM; + /* protect tsk->signal and tsk->sighand from disappearing */ + read_lock(&tasklist_lock); + if (!tsk->sighand) { + retval = -ESRCH; + goto out; + } + retval = security_task_setrlimit(tsk, resource, new_rlim); if (retval) - return retval; + goto out; if (resource == RLIMIT_CPU && new_rlim->rlim_cur == 0) { /* @@ -1286,6 +1294,7 @@ int setrlimit(struct task_struct *tsk, unsigned int resource, update_rlimit_cpu(tsk, new_rlim->rlim_cur); out: + read_unlock(&tasklist_lock); return retval; } |