diff options
| author | Jan Kara <jack@suse.cz> | 2015-06-02 17:08:29 +0200 |
|---|---|---|
| committer | Sasha Levin <alexander.levin@verizon.com> | 2016-08-22 12:23:14 -0400 |
| commit | c786cc5ea29cca704eed6af508d32c9e0d498b77 (patch) | |
| tree | 2b9984dfa4cc1aadcb1433a18e01566f8a6c4126 /kernel | |
| parent | eeeec2883cd91c6ad44c41c80ac70f028e97997b (diff) | |
audit: Fix check of return value of strnlen_user()
[ Upstream commit 0b08c5e59441d08ab4b5e72afefd5cd98a4d83df ]
strnlen_user() returns 0 when it hits fault, not -1. Fix the test in
audit_log_single_execve_arg(). Luckily this shouldn't ever happen unless
there's a kernel bug so it's mostly a cosmetic fix.
CC: Paul Moore <pmoore@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/auditsc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/auditsc.c b/kernel/auditsc.c index cc3416f0deda..c06f13fa5a99 100644 --- a/kernel/auditsc.c +++ b/kernel/auditsc.c @@ -1046,7 +1046,7 @@ static int audit_log_single_execve_arg(struct audit_context *context, * for strings that are too long, we should not have created * any. */ - if (unlikely((len == -1) || len > MAX_ARG_STRLEN - 1)) { + if (unlikely((len == 0) || len > MAX_ARG_STRLEN - 1)) { WARN_ON(1); send_sig(SIGKILL, current, 0); return -1; |