diff options
| author | Jean Delvare <jdelvare@suse.de> | 2016-01-18 17:06:05 +0100 |
|---|---|---|
| committer | Luis Henriques <luis.henriques@canonical.com> | 2016-02-02 19:10:02 +0000 |
| commit | 998c8c3c192d1f2c48aaf127c86b2483febb2c21 (patch) | |
| tree | 173499210757b35bb2e0b7a9019a428a108a3f6c /lib | |
| parent | f608afd0ae111abb0edc3e64a2e7e69b44f02702 (diff) | |
crypto: crc32c - Fix crc32c soft dependency
commit fd7f6727102a1ccf6b4c1dfcc631f9b546526b26 upstream.
I don't think it makes sense for a module to have a soft dependency
on itself. This seems quite cyclic by nature and I can't see what
purpose it could serve.
OTOH libcrc32c calls crypto_alloc_shash("crc32c", 0, 0) so it pretty
much assumes that some incarnation of the "crc32c" hash algorithm has
been loaded. Therefore it makes sense to have the soft dependency
there (as crc-t10dif does.)
Cc: Tim Chen <tim.c.chen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/libcrc32c.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/libcrc32c.c b/lib/libcrc32c.c index b3131f5cf8a2..b5c1aa06898c 100644 --- a/lib/libcrc32c.c +++ b/lib/libcrc32c.c @@ -76,3 +76,4 @@ module_exit(libcrc32c_mod_fini); MODULE_AUTHOR("Clay Haapala <chaapala@cisco.com>"); MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations"); MODULE_LICENSE("GPL"); +MODULE_SOFTDEP("pre: crc32c"); |