diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2013-11-05 17:06:35 +1100 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2013-11-05 17:40:04 +1100 |
commit | 383ac048456fae2016c0a3754514ae7bb5d19103 (patch) | |
tree | 79244a14b43751caccfa88c22bfe5cb90acdfd27 /mm | |
parent | 06d8a7b8573a85a3bd87f676573b53caf234b532 (diff) |
mm-hugetlb-convert-hugetlbfs-to-use-split-pmd-lock-checkpatch-fixes
ERROR: code indent should use tabs where possible
#65: FILE: include/linux/hugetlb.h:396:
+ struct mm_struct *mm, pte_t *pte)$
WARNING: please, no spaces at the start of a line
#65: FILE: include/linux/hugetlb.h:396:
+ struct mm_struct *mm, pte_t *pte)$
WARNING: please, no spaces at the start of a line
#67: FILE: include/linux/hugetlb.h:398:
+ if (huge_page_size(h) == PMD_SIZE)$
WARNING: suspect code indent for conditional statements (7, 15)
#67: FILE: include/linux/hugetlb.h:398:
+ if (huge_page_size(h) == PMD_SIZE)
+ return pmd_lockptr(mm, (pmd_t *) pte);
ERROR: code indent should use tabs where possible
#68: FILE: include/linux/hugetlb.h:399:
+ return pmd_lockptr(mm, (pmd_t *) pte);$
WARNING: please, no spaces at the start of a line
#68: FILE: include/linux/hugetlb.h:399:
+ return pmd_lockptr(mm, (pmd_t *) pte);$
WARNING: please, no spaces at the start of a line
#69: FILE: include/linux/hugetlb.h:400:
+ VM_BUG_ON(huge_page_size(h) == PAGE_SIZE);$
WARNING: please, no spaces at the start of a line
#70: FILE: include/linux/hugetlb.h:401:
+ return &mm->page_table_lock;$
ERROR: code indent should use tabs where possible
#90: FILE: include/linux/hugetlb.h:436:
+ struct mm_struct *mm, pte_t *pte)$
WARNING: please, no spaces at the start of a line
#90: FILE: include/linux/hugetlb.h:436:
+ struct mm_struct *mm, pte_t *pte)$
WARNING: please, no spaces at the start of a line
#92: FILE: include/linux/hugetlb.h:438:
+ return &mm->page_table_lock;$
ERROR: code indent should use tabs where possible
#97: FILE: include/linux/hugetlb.h:443:
+ struct mm_struct *mm, pte_t *pte)$
WARNING: please, no spaces at the start of a line
#97: FILE: include/linux/hugetlb.h:443:
+ struct mm_struct *mm, pte_t *pte)$
WARNING: please, no spaces at the start of a line
#99: FILE: include/linux/hugetlb.h:445:
+ spinlock_t *ptl;$
WARNING: please, no spaces at the start of a line
#100: FILE: include/linux/hugetlb.h:446:
+ ptl = huge_pte_lockptr(h, mm, pte);$
WARNING: please, no spaces at the start of a line
#101: FILE: include/linux/hugetlb.h:447:
+ spin_lock(ptl);$
WARNING: please, no spaces at the start of a line
#102: FILE: include/linux/hugetlb.h:448:
+ return ptl;$
WARNING: line over 80 characters
#264: FILE: mm/hugetlb.c:2668:
+ * race occurs while re-acquiring page table lock, and
total: 4 errors, 14 warnings, 474 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
./patches/mm-hugetlb-convert-hugetlbfs-to-use-split-pmd-lock.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm')
-rw-r--r-- | mm/hugetlb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 46d6073249e6..7d57af21f49e 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2679,8 +2679,8 @@ retry_avoidcopy: if (likely(pte_same(huge_ptep_get(ptep), pte))) goto retry_avoidcopy; /* - * race occurs while re-acquiring page table lock, and - * our job is done. + * race occurs while re-acquiring page table + * lock, and our job is done. */ return 0; } |