diff options
| author | Alvin Šipraga <alsi@bang-olufsen.dk> | 2021-10-12 13:27:31 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-10-20 11:57:55 +0200 |
| commit | 38eaccdcc81173c2f78e9936dce6cee29549988c (patch) | |
| tree | f8b9062e1613f4cdb995154c97915ce5b533cbed /net/dsa/switch.c | |
| parent | 383239a33cf29ebee9ce0d4e0e5c900b77a16148 (diff) | |
net: dsa: fix spurious error message when unoffloaded port leaves bridge
commit 43a4b4dbd48c9006ef64df3a12acf33bdfe11c61 upstream.
Flip the sign of a return value check, thereby suppressing the following
spurious error:
port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP
... which is emitted when removing an unoffloaded DSA switch port from a
bridge.
Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20211012112730.3429157-1-alvin@pqrs.dk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net/dsa/switch.c')
| -rw-r--r-- | net/dsa/switch.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/dsa/switch.c b/net/dsa/switch.c index 5ece05dfd8f2..9ef912571332 100644 --- a/net/dsa/switch.c +++ b/net/dsa/switch.c @@ -148,7 +148,7 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds, if (extack._msg) dev_err(ds->dev, "port %d: %s\n", info->port, extack._msg); - if (err && err != EOPNOTSUPP) + if (err && err != -EOPNOTSUPP) return err; } return 0; |