summaryrefslogtreecommitdiff
path: root/net/sched/sch_skbprio.c
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2020-05-02 20:09:25 -0700
committerDavid S. Miller <davem@davemloft.net>2020-05-03 15:52:13 -0700
commit2761121af87de45951989a0adada917837d8fa82 (patch)
tree2a7faebf0e32074ba10339ed0b0a43adab622bd3 /net/sched/sch_skbprio.c
parentdc30b4059f6e2abf3712ab537c8718562b21c45d (diff)
net_sched: sch_skbprio: add message validation to skbprio_change()
Do not assume the attribute has the right size. Fixes: aea5f654e6b7 ("net/sched: add skbprio scheduler") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/sched/sch_skbprio.c')
-rw-r--r--net/sched/sch_skbprio.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/net/sched/sch_skbprio.c b/net/sched/sch_skbprio.c
index 0fb10abf7579..7a5e4c454715 100644
--- a/net/sched/sch_skbprio.c
+++ b/net/sched/sch_skbprio.c
@@ -169,6 +169,9 @@ static int skbprio_change(struct Qdisc *sch, struct nlattr *opt,
{
struct tc_skbprio_qopt *ctl = nla_data(opt);
+ if (opt->nla_len != nla_attr_size(sizeof(*ctl)))
+ return -EINVAL;
+
sch->limit = ctl->limit;
return 0;
}