summaryrefslogtreecommitdiff
path: root/net/tipc
diff options
context:
space:
mode:
authorColin Ian King <colin.i.king@gmail.com>2024-04-11 10:17:04 +0100
committerJakub Kicinski <kuba@kernel.org>2024-04-12 19:07:31 -0700
commit195b7fc53c6f45feb0f649c7c68af70900928253 (patch)
treeeb4b114d3d2d1f8f49644bae1b0071e7cfa826a5 /net/tipc
parentd13b05962369bade0fb8e2d55af56492f866cd36 (diff)
tipc: remove redundant assignment to ret, simplify code
Variable err is being assigned a zero value and it is never read afterwards in either the break path or continue path, the assignment is redundant and can be removed. With it removed, the if statement can also be simplified. Cleans up clang scan warning: net/tipc/socket.c:3570:5: warning: Value stored to 'err' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20240411091704.306752-1-colin.i.king@gmail.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/tipc')
-rw-r--r--net/tipc/socket.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index 7e4135db5816..798397b6811e 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -3565,11 +3565,8 @@ int tipc_nl_sk_walk(struct sk_buff *skb, struct netlink_callback *cb,
rhashtable_walk_start(iter);
while ((tsk = rhashtable_walk_next(iter)) != NULL) {
if (IS_ERR(tsk)) {
- err = PTR_ERR(tsk);
- if (err == -EAGAIN) {
- err = 0;
+ if (PTR_ERR(tsk) == -EAGAIN)
continue;
- }
break;
}