diff options
author | Andrew Morton <akpm@linux-foundation.org> | 2013-02-20 13:17:04 +1100 |
---|---|---|
committer | Stephen Rothwell <sfr@canb.auug.org.au> | 2013-02-26 13:42:16 +1100 |
commit | ad7bff5f2c2c0ee3e464ea2e53c061af704c8ecf (patch) | |
tree | 3a481efed79d2e6446536983d16a28783ffec85c /net | |
parent | 4a8a2d1cc78b9587af34a47637f6a6ade2ff206c (diff) |
hlist-drop-the-node-parameter-from-iterators-checkpatch-fixes
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
ERROR: code indent should use tabs where possible
#939: FILE: drivers/atm/atmtcp.c:270:
+ sk_for_each(s, head) {$
WARNING: please, no spaces at the start of a line
#939: FILE: drivers/atm/atmtcp.c:270:
+ sk_for_each(s, head) {$
ERROR: space required before the open brace '{'
#2295: FILE: fs/dlm/lowcomms.c:238:
+ hlist_for_each_entry_safe(con, n, &connection_hash[i], list){
WARNING: line over 80 characters
#3070: FILE: include/linux/hashtable.h:122:
+ for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name); (bkt)++)\
WARNING: line over 80 characters
#3084: FILE: include/linux/hashtable.h:132:
+#define hash_for_each_rcu(name, bkt, obj, member) \
WARNING: line over 80 characters
#3085: FILE: include/linux/hashtable.h:133:
+ for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name); (bkt)++)\
WARNING: line over 80 characters
#3102: FILE: include/linux/hashtable.h:146:
+ for ((bkt) = 0, obj = NULL; obj == NULL && (bkt) < HASH_SIZE(name); (bkt)++)\
WARNING: line over 80 characters
#3132: FILE: include/linux/hashtable.h:170:
+ hlist_for_each_entry_rcu(obj, &name[hash_min(key, HASH_BITS(name))], member)
WARNING: line over 80 characters
#3147: FILE: include/linux/hashtable.h:181:
+#define hash_for_each_possible_safe(name, obj, tmp, member, key) \
WARNING: line over 80 characters
#3148: FILE: include/linux/hashtable.h:182:
+ hlist_for_each_entry_safe(obj, tmp, &name[hash_min(key, HASH_BITS(name))], member)
ERROR: Macros with complex values should be enclosed in parenthesis
#3188: FILE: include/linux/list.h:669:
+#define hlist_entry_safe(ptr, type, member) \
+ (ptr) ? hlist_entry(ptr, type, member) : NULL
WARNING: line over 80 characters
#3204: FILE: include/linux/list.h:678:
+#define hlist_for_each_entry(pos, head, member) \
WARNING: line over 80 characters
#3205: FILE: include/linux/list.h:679:
+ for (pos = hlist_entry_safe((head)->first, typeof(*(pos)), member); \
WARNING: line over 80 characters
#3206: FILE: include/linux/list.h:680:
+ pos; \
WARNING: line over 80 characters
#3221: FILE: include/linux/list.h:688:
+#define hlist_for_each_entry_continue(pos, member) \
WARNING: line over 80 characters
#3222: FILE: include/linux/list.h:689:
+ for (pos = hlist_entry_safe((pos)->member.next, typeof(*(pos)), member);\
WARNING: line over 80 characters
#3223: FILE: include/linux/list.h:690:
+ pos; \
WARNING: line over 80 characters
#3255: FILE: include/linux/list.h:709:
+#define hlist_for_each_entry_safe(pos, n, head, member) \
WARNING: please, no space before tabs
#3255: FILE: include/linux/list.h:709:
+#define hlist_for_each_entry_safe(pos, n, head, member) ^I^I^I\$
WARNING: line over 80 characters
#3256: FILE: include/linux/list.h:710:
+ for (pos = hlist_entry_safe((head)->first, typeof(*pos), member); \
WARNING: line over 80 characters
#3257: FILE: include/linux/list.h:711:
+ pos && ({ n = pos->member.next; 1; }); \
WARNING: line over 80 characters
#3297: FILE: include/linux/rculist.h:456:
+#define hlist_for_each_entry_rcu(pos, head, member) \
WARNING: line over 80 characters
#3298: FILE: include/linux/rculist.h:457:
+ for (pos = hlist_entry_safe (rcu_dereference_raw(hlist_first_rcu(head)),\
WARNING: space prohibited between function name and open parenthesis '('
#3298: FILE: include/linux/rculist.h:457:
+ for (pos = hlist_entry_safe (rcu_dereference_raw(hlist_first_rcu(head)),\
WARNING: line over 80 characters
#3299: FILE: include/linux/rculist.h:458:
+ typeof(*(pos)), member); \
WARNING: line over 80 characters
#3300: FILE: include/linux/rculist.h:459:
+ pos; \
WARNING: line over 80 characters
#3301: FILE: include/linux/rculist.h:460:
+ pos = hlist_entry_safe(rcu_dereference_raw(hlist_next_rcu( \
WARNING: line over 80 characters
#3321: FILE: include/linux/rculist.h:473:
+#define hlist_for_each_entry_rcu_bh(pos, head, member) \
WARNING: line over 80 characters
#3322: FILE: include/linux/rculist.h:474:
+ for (pos = hlist_entry_safe(rcu_dereference_bh(hlist_first_rcu(head)), \
WARNING: line over 80 characters
#3323: FILE: include/linux/rculist.h:475:
+ typeof(*(pos)), member); \
WARNING: line over 80 characters
#3324: FILE: include/linux/rculist.h:476:
+ pos; \
WARNING: line over 80 characters
#3325: FILE: include/linux/rculist.h:477:
+ pos = hlist_entry_safe(rcu_dereference_bh(hlist_next_rcu( \
WARNING: line over 80 characters
#3340: FILE: include/linux/rculist.h:485:
+#define hlist_for_each_entry_continue_rcu(pos, member) \
WARNING: line over 80 characters
#3341: FILE: include/linux/rculist.h:486:
+ for (pos = hlist_entry_safe(rcu_dereference((pos)->member.next), \
WARNING: line over 80 characters
#3342: FILE: include/linux/rculist.h:487:
+ typeof(*(pos)), member); \
WARNING: line over 80 characters
#3343: FILE: include/linux/rculist.h:488:
+ pos; \
WARNING: line over 80 characters
#3344: FILE: include/linux/rculist.h:489:
+ pos = hlist_entry_safe(rcu_dereference((pos)->member.next), \
ERROR: code indent should use tabs where possible
#3345: FILE: include/linux/rculist.h:490:
+^I ^I^Itypeof(*(pos)), member))$
WARNING: please, no space before tabs
#3345: FILE: include/linux/rculist.h:490:
+^I ^I^Itypeof(*(pos)), member))$
WARNING: line over 80 characters
#3359: FILE: include/linux/rculist.h:497:
+#define hlist_for_each_entry_continue_rcu_bh(pos, member) \
WARNING: line over 80 characters
#3360: FILE: include/linux/rculist.h:498:
+ for (pos = hlist_entry_safe(rcu_dereference_bh((pos)->member.next), \
WARNING: line over 80 characters
#3361: FILE: include/linux/rculist.h:499:
+ typeof(*(pos)), member); \
WARNING: line over 80 characters
#3362: FILE: include/linux/rculist.h:500:
+ pos; \
WARNING: line over 80 characters
#3363: FILE: include/linux/rculist.h:501:
+ pos = hlist_entry_safe(rcu_dereference_bh((pos)->member.next), \
ERROR: code indent should use tabs where possible
#3364: FILE: include/linux/rculist.h:502:
+^I ^I^Itypeof(*(pos)), member))$
WARNING: please, no space before tabs
#3364: FILE: include/linux/rculist.h:502:
+^I ^I^Itypeof(*(pos)), member))$
ERROR: do not use C99 // comments
#3817: FILE: kernel/smpboot.c:134:
+ //BUG_ON(td->cpu != smp_processor_id());
ERROR: do not use C99 // comments
#4452: FILE: net/9p/trans_virtio.c:658:
+ //.zc_request = p9_virtio_zc_request,
WARNING: line over 80 characters
#7049: FILE: net/decnet/af_decnet.c:418:
+ sk_for_each(sk, &dn_sk_hash[le16_to_cpu(cb->dst_port) & DN_SK_HASH_MASK]) {
WARNING: space prohibited between function name and open parenthesis '('
#7696: FILE: net/ipv4/raw.c:123:
+ sk_for_each_from (sk) {
ERROR: spaces required around that '=' (ctx:VxV)
#7697: FILE: net/ipv4/raw.c:124:
+ struct inet_sock *inet=inet_sk(sk);
^
WARNING: line over 80 characters
#7698: FILE: net/ipv4/raw.c:125:
+ if (net_eq(sock_net(sk), net) && inet->inet_num == num && !(inet->inet_daddr && inet->inet_daddr != raddr) && !(inet->inet_rcv_saddr && inet->inet_rcv_saddr != laddr) && !(sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif))
WARNING: space prohibited between function name and open parenthesis '('
#8085: FILE: net/ipv6/raw.c:100:
+ sk_for_each_from (sk)
ERROR: spaces required around that '=' (ctx:VxV)
#8087: FILE: net/ipv6/raw.c:102:
+ struct ipv6_pinfo *np=inet6_sk(sk);
^
WARNING: line over 80 characters
#8090: FILE: net/ipv6/raw.c:105:
+ if (!ipv6_addr_any(&np->daddr) && !ipv6_addr_equal(&np->daddr, rmt_addr))
WARNING: line over 80 characters
#8092: FILE: net/ipv6/raw.c:107:
+ if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif)
WARNING: Too many leading tabs - consider code refactoring
#8092: FILE: net/ipv6/raw.c:107:
+ if (sk->sk_bound_dev_if && sk->sk_bound_dev_if != dif)
WARNING: line over 80 characters
#8094: FILE: net/ipv6/raw.c:109:
+ if (!ipv6_addr_any(&np->rcv_saddr)) {
WARNING: Too many leading tabs - consider code refactoring
#8094: FILE: net/ipv6/raw.c:109:
+ if (!ipv6_addr_any(&np->rcv_saddr)) {
WARNING: line over 80 characters
#8095: FILE: net/ipv6/raw.c:110:
+ if (ipv6_addr_equal(&np->rcv_saddr, loc_addr))
WARNING: Too many leading tabs - consider code refactoring
#8095: FILE: net/ipv6/raw.c:110:
+ if (ipv6_addr_equal(&np->rcv_saddr, loc_addr))
WARNING: line over 80 characters
#8096: FILE: net/ipv6/raw.c:111:
+ goto found;
WARNING: line over 80 characters
#8097: FILE: net/ipv6/raw.c:112:
+ if (is_multicast && inet6_mc_check(sk, loc_addr, rmt_addr))
WARNING: Too many leading tabs - consider code refactoring
#8097: FILE: net/ipv6/raw.c:112:
+ if (is_multicast && inet6_mc_check(sk, loc_addr, rmt_addr))
WARNING: line over 80 characters
#8098: FILE: net/ipv6/raw.c:113:
+ goto found;
WARNING: line over 80 characters
#8099: FILE: net/ipv6/raw.c:114:
+ continue;
WARNING: line over 80 characters
#8101: FILE: net/ipv6/raw.c:116:
+ goto found;
WARNING: line over 80 characters
#8413: FILE: net/l2tp/l2tp_core.c:285:
+ hlist_for_each_entry(session, &tunnel->session_hlist[hash], hlist) {
WARNING: line over 80 characters
#8427: FILE: net/l2tp/l2tp_core.c:310:
+ hlist_for_each_entry_rcu(session, &pn->l2tp_session_hlist[hash], global_hlist) {
total: 9 errors, 60 warnings, 9471 lines checked
NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
scripts/cleanfile
./patches/hlist-drop-the-node-parameter-from-iterators.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Please run checkpatch prior to sending patches
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'net')
0 files changed, 0 insertions, 0 deletions