diff options
| author | Parav Pandit <parav@nvidia.com> | 2020-11-25 11:16:20 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-12-08 10:41:59 +0100 |
| commit | d2d2a882000c6de3a106a0932a33b2b56d405b6c (patch) | |
| tree | d514d020fa682de17a9dac8b6943163544018a37 /net | |
| parent | 9670490edfc442d0287726a28ec7dd5f2cab0969 (diff) | |
devlink: Make sure devlink instance and port are in same net namespace
[ Upstream commit a7b43649507dae4e55ff0087cad4e4dd1c6d5b99 ]
When devlink reload operation is not used, netdev of an Ethernet port may
be present in different net namespace than the net namespace of the
devlink instance.
Ensure that both the devlink instance and devlink port netdev are located
in same net namespace.
Fixes: 070c63f20f6c ("net: devlink: allow to change namespaces during reload")
Signed-off-by: Parav Pandit <parav@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/devlink.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index 37892d6f198e..333148d4e8f7 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -626,9 +626,10 @@ static int devlink_nl_port_fill(struct sk_buff *msg, struct devlink *devlink, devlink_port->desired_type)) goto nla_put_failure_type_locked; if (devlink_port->type == DEVLINK_PORT_TYPE_ETH) { + struct net *net = devlink_net(devlink_port->devlink); struct net_device *netdev = devlink_port->type_dev; - if (netdev && + if (netdev && net_eq(net, dev_net(netdev)) && (nla_put_u32(msg, DEVLINK_ATTR_PORT_NETDEV_IFINDEX, netdev->ifindex) || nla_put_string(msg, DEVLINK_ATTR_PORT_NETDEV_NAME, |